Skip to content

Allow side-effects to permissions#1069

Merged
GuillaumeRx merged 32 commits into
mainfrom
gr/add-side-effect-permission-controller
Mar 28, 2023
Merged

Allow side-effects to permissions#1069
GuillaumeRx merged 32 commits into
mainfrom
gr/add-side-effect-permission-controller

Conversation

@GuillaumeRx
Copy link
Copy Markdown
Contributor

@GuillaumeRx GuillaumeRx commented Jan 18, 2023 •
edited
Loading

Closes: #1057

This allows permissions to have side-effects. The side-effects are defined in the permission constraint and is handled after the user approved the permissions.

It allows permissions to have a onPermitted side-effect and a onFailure side-effect.

FrederikBolding
FrederikBolding reviewed Jan 18, 2023
View reviewed changes
Comment thread packages/permission-controller/src/PermissionController.ts Outdated
Gudahtt
Gudahtt reviewed Feb 7, 2023
View reviewed changes
Comment thread packages/permission-controller/src/Permission.ts Outdated
Gudahtt
Gudahtt reviewed Feb 7, 2023
View reviewed changes
Comment thread packages/permission-controller/src/Permission.ts Outdated
@GuillaumeRx GuillaumeRx force-pushed the gr/add-side-effect-permission-controller branch from 7453112 to 2ee530b Compare February 8, 2023 14:10
@GuillaumeRx GuillaumeRx force-pushed the gr/add-side-effect-permission-controller branch 2 times, most recently from 8fb1e60 to 9771e61 Compare February 14, 2023 11:06
@GuillaumeRx GuillaumeRx force-pushed the gr/add-side-effect-permission-controller branch from a0614e1 to f9e11ce Compare February 16, 2023 12:05
@GuillaumeRx GuillaumeRx marked this pull request as ready for review February 16, 2023 12:05
@GuillaumeRx GuillaumeRx requested a review from a team as a code owner February 16, 2023 12:05
@GuillaumeRx GuillaumeRx self-assigned this Feb 16, 2023
@GuillaumeRx GuillaumeRx force-pushed the gr/add-side-effect-permission-controller branch from 495d100 to f183856 Compare March 21, 2023 17:49
@GuillaumeRx
Copy link
Copy Markdown
Contributor Author

GuillaumeRx commented Mar 22, 2023

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 22, 2023

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask/address-book-controller": "2.0.0-preview.1d81ae6",
  "@metamask/announcement-controller": "3.0.0-preview.1d81ae6",
  "@metamask/approval-controller": "2.0.0-preview.1d81ae6",
  "@metamask/assets-controllers": "5.0.0-preview.1d81ae6",
  "@metamask/base-controller": "2.0.0-preview.1d81ae6",
  "@metamask/composable-controller": "2.0.0-preview.1d81ae6",
  "@metamask/controller-utils": "3.0.0-preview.1d81ae6",
  "@metamask/ens-controller": "2.0.0-preview.1d81ae6",
  "@metamask/gas-fee-controller": "4.0.0-preview.1d81ae6",
  "@metamask/keyring-controller": "4.0.0-preview.1d81ae6",
  "@metamask/message-manager": "2.0.0-preview.1d81ae6",
  "@metamask/network-controller": "5.0.0-preview.1d81ae6",
  "@metamask/notification-controller": "2.0.0-preview.1d81ae6",
  "@metamask/permission-controller": "3.0.0-preview.1d81ae6",
  "@metamask/phishing-controller": "3.0.0-preview.1d81ae6",
  "@metamask/preferences-controller": "2.1.0-preview.1d81ae6",
  "@metamask/rate-limit-controller": "2.0.0-preview.1d81ae6",
  "@metamask/subject-metadata-controller": "2.0.0-preview.1d81ae6",
  "@metamask/transaction-controller": "4.0.0-preview.1d81ae6"
}

@GuillaumeRx
Copy link
Copy Markdown
Contributor Author

GuillaumeRx commented Mar 22, 2023

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 22, 2023

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask/address-book-controller": "2.0.0-preview.0a19a24",
  "@metamask/announcement-controller": "3.0.0-preview.0a19a24",
  "@metamask/approval-controller": "2.0.0-preview.0a19a24",
  "@metamask/assets-controllers": "5.0.0-preview.0a19a24",
  "@metamask/base-controller": "2.0.0-preview.0a19a24",
  "@metamask/composable-controller": "2.0.0-preview.0a19a24",
  "@metamask/controller-utils": "3.0.0-preview.0a19a24",
  "@metamask/ens-controller": "2.0.0-preview.0a19a24",
  "@metamask/gas-fee-controller": "4.0.0-preview.0a19a24",
  "@metamask/keyring-controller": "4.0.0-preview.0a19a24",
  "@metamask/message-manager": "2.0.0-preview.0a19a24",
  "@metamask/network-controller": "5.0.0-preview.0a19a24",
  "@metamask/notification-controller": "2.0.0-preview.0a19a24",
  "@metamask/permission-controller": "3.0.0-preview.0a19a24",
  "@metamask/phishing-controller": "3.0.0-preview.0a19a24",
  "@metamask/preferences-controller": "2.1.0-preview.0a19a24",
  "@metamask/rate-limit-controller": "2.0.0-preview.0a19a24",
  "@metamask/subject-metadata-controller": "2.0.0-preview.0a19a24",
  "@metamask/transaction-controller": "4.0.0-preview.0a19a24"
}

@GuillaumeRx
Copy link
Copy Markdown
Contributor Author

GuillaumeRx commented Mar 22, 2023

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 22, 2023

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask/address-book-controller": "2.0.0-preview.44f4e92",
  "@metamask/announcement-controller": "3.0.0-preview.44f4e92",
  "@metamask/approval-controller": "2.0.0-preview.44f4e92",
  "@metamask/assets-controllers": "5.0.0-preview.44f4e92",
  "@metamask/base-controller": "2.0.0-preview.44f4e92",
  "@metamask/composable-controller": "2.0.0-preview.44f4e92",
  "@metamask/controller-utils": "3.0.0-preview.44f4e92",
  "@metamask/ens-controller": "2.0.0-preview.44f4e92",
  "@metamask/gas-fee-controller": "4.0.0-preview.44f4e92",
  "@metamask/keyring-controller": "4.0.0-preview.44f4e92",
  "@metamask/message-manager": "2.0.0-preview.44f4e92",
  "@metamask/network-controller": "5.0.0-preview.44f4e92",
  "@metamask/notification-controller": "2.0.0-preview.44f4e92",
  "@metamask/permission-controller": "3.0.0-preview.44f4e92",
  "@metamask/phishing-controller": "3.0.0-preview.44f4e92",
  "@metamask/preferences-controller": "2.1.0-preview.44f4e92",
  "@metamask/rate-limit-controller": "2.0.0-preview.44f4e92",
  "@metamask/subject-metadata-controller": "2.0.0-preview.44f4e92",
  "@metamask/transaction-controller": "4.0.0-preview.44f4e92"
}

matthewwalsh0
matthewwalsh0 reviewed Mar 22, 2023
View reviewed changes
Comment thread packages/permission-controller/src/PermissionController.ts Outdated
matthewwalsh0
matthewwalsh0 reviewed Mar 22, 2023
View reviewed changes
Comment thread packages/approval-controller/src/ApprovalController.ts Outdated
matthewwalsh0
matthewwalsh0 reviewed Mar 22, 2023
View reviewed changes
Comment thread packages/approval-controller/src/ApprovalController.ts Outdated
matthewwalsh0
matthewwalsh0 reviewed Mar 22, 2023
View reviewed changes
Comment thread packages/approval-controller/src/ApprovalController.ts Outdated
matthewwalsh0
matthewwalsh0 reviewed Mar 22, 2023
View reviewed changes
Comment thread packages/approval-controller/src/ApprovalController.ts Outdated
matthewwalsh0
matthewwalsh0 reviewed Mar 22, 2023
View reviewed changes
Comment thread packages/approval-controller/src/ApprovalController.ts Outdated
FrederikBolding
FrederikBolding reviewed Mar 23, 2023
View reviewed changes
Comment thread tsconfig.packages.json Outdated
Comment thread packages/approval-controller/src/ApprovalController.ts Outdated
Comment thread packages/permission-controller/src/PermissionController.ts Outdated
Comment thread packages/approval-controller/src/ApprovalController.ts Outdated
Comment thread packages/approval-controller/src/ApprovalController.ts Outdated
Mrtenz
Mrtenz previously requested changes Mar 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a PR description rather than just linking to an issue.

@GuillaumeRx GuillaumeRx dismissed a stale review via e05cd7d March 23, 2023 11:41
@GuillaumeRx GuillaumeRx force-pushed the gr/add-side-effect-permission-controller branch from 73f2318 to e05cd7d Compare March 23, 2023 11:41
@GuillaumeRx
re-add passing of side-effects to approvals
018ff3d
@GuillaumeRx
fix approval resolving
87a9ede
@GuillaumeRx
add tests to PermissionController
9810c15
@GuillaumeRx
adjust branch coverage threshold for permission controller
c9542e9
@GuillaumeRx
pass messenger call method to side effect handler params
d3ffd3e
@GuillaumeRx
rework types
8e54321
@GuillaumeRx
display error on failure
e5ed6dc
@GuillaumeRx
return values from side-effects
b3bf4fd
@GuillaumeRx
add missing test
4c2ec64
@GuillaumeRx
pass entire messenger
85dc902
@GuillaumeRx
update type
6d56a40
@GuillaumeRx
update side-effect messenger type
0ac9add
@GuillaumeRx
address requested changes and impove sideEffect types
f046d83
@GuillaumeRx
add missing parameter to add jsdoc
2442055
@GuillaumeRx
move side-effect handling to PermissionController
d051bad
@GuillaumeRx
fixing tests
009ad82
@GuillaumeRx
add tests
3a048ad
@GuillaumeRx
revert useless change
04f051d
@GuillaumeRx
add JSDocs and address requested changes
75baa19
@GuillaumeRx
add more JSDocs
13327bf
@GuillaumeRx
pass the entire approved request to side-effects
e229a9b
@GuillaumeRx
fix side effect return mappin unexpected behaviour
ff1dffb
@GuillaumeRx GuillaumeRx force-pushed the gr/add-side-effect-permission-controller branch from df812ce to ff1dffb Compare March 28, 2023 17:27
@GuillaumeRx GuillaumeRx mentioned this pull request Mar 28, 2023
Merged
@GuillaumeRx GuillaumeRx merged commit 359cc3c into main Mar 28, 2023
@GuillaumeRx GuillaumeRx deleted the gr/add-side-effect-permission-controller branch March 28, 2023 17:48
@adonesky1 adonesky1 mentioned this pull request Oct 25, 2023
Merged
3 tasks
@rekmarks rekmarks mentioned this pull request Apr 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt left review comments

@cryptotavares cryptotavares cryptotavares left review comments

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@Mrtenz Mrtenz Mrtenz left review comments

Assignees

@GuillaumeRx GuillaumeRx

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow side-effects of permissions in PermissionController

6 participants

@GuillaumeRx @FrederikBolding @Gudahtt @Mrtenz @cryptotavares @matthewwalsh0